Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(responsemanager): add listener for completed responses #64

Merged
merged 1 commit into from
Apr 21, 2020
Merged

feat(responsemanager): add listener for completed responses #64

merged 1 commit into from
Apr 21, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Provide a way for graphsync user to determine when it finishes responding to a received request

Implementation

  • Add one last hook -- this time just a listener -- that gets called on the responder side when we finish responding to requests
  • modify PeerResponseSender to provide correct response status information for completed requests

@hannahhoward hannahhoward force-pushed the feat/response-complete-listener branch from 05e0db9 to 1889ca0 Compare April 21, 2020 23:32
@hannahhoward hannahhoward changed the base branch from feat/update-requests to master April 21, 2020 23:32
@hannahhoward hannahhoward merged commit 1c39fe6 into master Apr 21, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
@mvdan mvdan deleted the feat/response-complete-listener branch December 15, 2021 14:15
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
@Stebalien
Update changelog for 0.6.0 release (#64)
8dad93e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hannahhoward